yiguolei commented on code in PR #14080:
URL: https://github.com/apache/doris/pull/14080#discussion_r1017377787
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -476,10 +476,9 @@ Status TabletsChannel::add_batch(const
TabletWriterAddRequest& request,
if (!st.ok()) {
auto err_msg = strings::Substitute(
"tablet writer write failed, tablet_id=$0, txn_id=$1,
err=$2"
- ", errcode=$3, msg:$4",
- tablet_to_rowidxs_it.first, _txn_id, st.code(),
st.precise_code(),
- st.get_error_msg());
- LOG(WARNING) << err_msg;
+ ", precise_code=$3",
+ tablet_to_rowidxs_it.first, _txn_id, st.code(),
st.precise_code());
+ LOG(WARNING) << err_msg << " bt:" << st.get_error_msg();
Review Comment:
Please do not use error code or precise code as error message. Better to use
exception stack since we may remove error code mechanism in the future. We
will use exception instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
