dataroaring commented on PR #53144: URL: https://github.com/apache/doris/pull/53144#issuecomment-3712268472
**Follow-up on `send_error()` missing `finish_send_reply()`:** After deeper investigation, this is **NOT a bug**. Here's why: 1. `StreamLoadAction` inherits from `HttpHandler` (not `HttpHandlerWithAuth`) 2. `StreamLoadAction` never calls `send_error()` - it uses its own `_send_reply()` method for all error paths 3. `mark_send_reply()` is only called in `StreamLoadAction::on_header()`, marking it as `REPLY_ASYNC` 4. Other handlers (like `HttpHandlerWithAuth`) that use `send_error()` never call `mark_send_reply()`, so they stay in default `REPLY_SYNC` mode 5. In `REPLY_SYNC` mode, `wait_finish_send_reply()` returns immediately without waiting Therefore, `send_error()` doesn't need `finish_send_reply()` because it's never called from an async reply context. The code is correct as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
