englefly commented on code in PR #59517:
URL: https://github.com/apache/doris/pull/59517#discussion_r2663512980
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/rewrite/CostBasedRewriteJob.java:
##########
@@ -94,8 +111,7 @@ public void execute(JobContext jobContext) {
}
// If the candidate applied cbo rule is better, replace the original
plan with it.
if (appliedCboRuleCost.get().first.getValue() <
skipCboRuleCost.get().first.getValue()) {
- currentCtx.addPlanProcesses(applyCboRuleCtx.getPlanProcesses());
Review Comment:
假设plan1 被costBaseRule 改写为 plan2， 然后再被后续rule（不包含其他costBasedRule）改写为plan3
如果选中了costBaseRule的改写，那么退出costBaseRule后，我们应该从plan2继续改写。这里的plan process 记录的是
plan2 到plan3 的过程
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
