This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 54d012e3b3b [chore](scan) remove unused code (#59565)
54d012e3b3b is described below
commit 54d012e3b3b9e5fdd18fd486c9f01f65576959c4
Author: Sun Chenyang <[email protected]>
AuthorDate: Tue Jan 6 19:08:01 2026 +0800
[chore](scan) remove unused code (#59565)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/pipeline/exec/scan_operator.cpp | 64 +++++++++++++---------------------
1 file changed, 25 insertions(+), 39 deletions(-)
diff --git a/be/src/pipeline/exec/scan_operator.cpp
b/be/src/pipeline/exec/scan_operator.cpp
index 122ca9dd444..228188b0352 100644
--- a/be/src/pipeline/exec/scan_operator.cpp
+++ b/be/src/pipeline/exec/scan_operator.cpp
@@ -197,51 +197,40 @@ Status
ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
_slot_id_to_value_range[slot->id()] = std::move(range);
\
break;
\
}
-#define APPLY_FOR_PRIMITIVE_TYPE(M) \
- M(TINYINT) \
- M(SMALLINT) \
- M(INT) \
- M(BIGINT) \
- M(LARGEINT) \
- M(FLOAT) \
- M(DOUBLE) \
- M(CHAR) \
- M(DATE) \
- M(DATETIME) \
- M(DATEV2) \
- M(DATETIMEV2) \
- M(TIMESTAMPTZ) \
- M(VARCHAR) \
- M(STRING) \
- M(HLL) \
- M(DECIMAL32) \
- M(DECIMAL64) \
- M(DECIMAL128I) \
- M(DECIMAL256) \
- M(DECIMALV2) \
- M(BOOLEAN) \
- M(IPV4) \
+#define APPLY_FOR_SCALAR_TYPE(M) \
+ M(TINYINT) \
+ M(SMALLINT) \
+ M(INT) \
+ M(BIGINT) \
+ M(LARGEINT) \
+ M(FLOAT) \
+ M(DOUBLE) \
+ M(CHAR) \
+ M(DATE) \
+ M(DATETIME) \
+ M(DATEV2) \
+ M(DATETIMEV2) \
+ M(TIMESTAMPTZ) \
+ M(VARCHAR) \
+ M(STRING) \
+ M(HLL) \
+ M(DECIMAL32) \
+ M(DECIMAL64) \
+ M(DECIMAL128I) \
+ M(DECIMAL256) \
+ M(DECIMALV2) \
+ M(BOOLEAN) \
+ M(IPV4) \
M(IPV6)
- APPLY_FOR_PRIMITIVE_TYPE(M)
+ APPLY_FOR_SCALAR_TYPE(M)
#undef M
default: {
- VLOG_CRITICAL << "Unsupported Normalize Slot [ColName=" <<
slot->col_name() << "]";
break;
}
}
};
for (auto& slot : slots) {
- auto type = slot->type()->get_primitive_type();
- if (type == TYPE_ARRAY) {
- type = assert_cast<const vectorized::DataTypeArray*>(
- vectorized::remove_nullable(slot->type()).get())
- ->get_nested_type()
- ->get_primitive_type();
- if (type == TYPE_ARRAY) {
- continue;
- }
- }
init_value_range(slot, slot->type());
_slot_id_to_predicates.insert(
{slot->id(), std::vector<std::shared_ptr<ColumnPredicate>>()});
@@ -577,9 +566,6 @@ bool
ScanLocalState<Derived>::_is_predicate_acting_on_slot(const vectorized::VEx
if (_slot_id_to_predicates.end() == entry) {
return false;
}
- if (is_complex_type(slot_ref->data_type()->get_primitive_type())) {
- return false;
- }
auto sid_to_range = _slot_id_to_value_range.find(slot_ref->slot_id());
if (_slot_id_to_value_range.end() == sid_to_range) {
return false;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
