seawinde commented on code in PR #59594:
URL: https://github.com/apache/doris/pull/59594#discussion_r2666928919
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -371,7 +373,7 @@ protected List<Plan> doRewrite(StructInfo queryStructInfo,
CascadesContext casca
return rewriteResults;
}
boolean partitionNeedUnion =
PartitionCompensator.needUnionRewrite(invalidPartitions, cascadesContext);
- boolean canUnionRewrite = canUnionRewrite(queryPlan,
+ canUnionRewrite = canUnionRewrite && canUnionRewrite(queryPlan,
Review Comment:
Hi, Using materialized views for transparent query rewriting should ensure
data correctness unless the user explicitly specifies that incorrect data is
allowed. This behavior change is reasonable. Also, a side question: Why is
union rewrite disabled for materialized views using external tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
