BiteTheDDDDt opened a new pull request, #59638:
URL: https://github.com/apache/doris/pull/59638
This pull request introduces a delayed deletion mechanism for `QueryContext`
objects in the fragment manager to ensure that runtime filter merging works
correctly after a query reaches its end-of-stream (EOS). The main changes
involve adding a new map to retain query contexts temporarily, modifying the
lifecycle management of query contexts, and introducing utility methods to
support this behavior.
**Query Context Lifecycle Management:**
* Added a new member `_query_ctx_map_delay_delete` to `FragmentMgr` to keep
`QueryContext` objects alive for a short period after query EOS, ensuring that
the runtime filter coordinator can complete its work.
* Modified `FragmentMgr::remove_query_context` to erase entries from
`_query_ctx_map_delay_delete` as part of the cleanup process.
* Updated the `QueryContext` destructor to call `remove_query_context` only
if the fragment manager is available, preventing issues during unit tests.
**Runtime Filter Merge Coordination:**
* In `FragmentMgr::_get_or_create_query_ctx`, now inserts the `QueryContext`
into `_query_ctx_map_delay_delete` if the runtime filter merge handler is not
empty, ensuring the context is retained for merging.
* Added an `empty()` method to `RuntimeFilterMergeControllerEntity` to check
if the filter map is empty, which is used to determine if delayed deletion is
needed.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
