BiteTheDDDDt opened a new pull request, #59770:
URL: https://github.com/apache/doris/pull/59770
Currently, the reading and writing of conjuncts are not using the same lock,
which may cause errors when reading conjuncts during vector expansion.
This pull request refactors how conjunct contexts are cloned in the scan
operator pipeline. The main change is moving the responsibility for cloning
conjunct contexts from the `ScanLocalState` class to the
`RuntimeFilterConsumerHelper` class, simplifying the interface and improving
encapsulation.
**Refactoring and responsibility shift:**
* Removed the `clone_conjunct_ctxs` method from `ScanLocalState` and its
base class, along with related members such as `_conjunct_lock`. This
simplifies the scan local state classes and reduces their responsibilities.
[[1]](diffhunk://#diff-ac38473f151ccd99db4ed80dfbfa176f4f957ae2f5335ce8fbb4f5dbb0e932e9L1091-L1102)
[[2]](diffhunk://#diff-f5a0db9faf0b649227b0126cca493d8dce22c9d497116fd480d7d018ce1696d2L71)
[[3]](diffhunk://#diff-f5a0db9faf0b649227b0126cca493d8dce22c9d497116fd480d7d018ce1696d2L125)
[[4]](diffhunk://#diff-f5a0db9faf0b649227b0126cca493d8dce22c9d497116fd480d7d018ce1696d2L155)
* Added a new `clone_conjunct_ctxs` method to `RuntimeFilterConsumerHelper`,
which now handles cloning of conjunct contexts, including locking and context
management.
[[1]](diffhunk://#diff-ed4cbc22dcb1b5d27652827cea0f12373591a9b06e3c857f0dd0e32f58422026R133-R143)
[[2]](diffhunk://#diff-61d96ad649abf519ee21143b6a4d9ed0c1b820ba273281ca8650a1e047d10f15R51-R54)
**Integration and usage updates:**
* Updated the `Scanner::try_append_late_arrival_runtime_filter` method to
use the new `clone_conjunct_ctxs` method from
`RuntimeFilterConsumerHelper` instead of the previous approach.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
