Mryange commented on code in PR #59775:
URL: https://github.com/apache/doris/pull/59775#discussion_r2681662611


##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -904,14 +928,22 @@ Status ScanLocalState<Derived>::_change_value_range(bool 
is_equal_op,
 template <typename Derived>
 template <PrimitiveType T>
 Status ScanLocalState<Derived>::_normalize_is_null_predicate(
-        vectorized::VExprContext* expr_ctx, const vectorized::VExprSPtr& root, 
SlotDescriptor* slot,
+        vectorized::VExprContext* expr_ctx, const vectorized::VExprSPtr& expr, 
SlotDescriptor* slot,
         std::vector<std::shared_ptr<ColumnPredicate>>& predicates, 
ColumnValueRange<T>& range,
         PushDownType* pdt) {
     std::shared_ptr<ColumnPredicate> pred = nullptr;
+    auto root = expr->is_rf_wrapper() ? expr->get_impl() : expr;

Review Comment:
   is_null会是rf吗?
   不过我觉得要不直接在_normalize_predicate里面统一处理吧。
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to