Copilot commented on code in PR #59787:
URL: https://github.com/apache/doris/pull/59787#discussion_r2681804174
##########
be/src/tools/paimon_cpp_demo.cpp:
##########
@@ -0,0 +1,10 @@
+// Minimal Paimon C++ link/ABI check for Doris BE.
Review Comment:
Missing Apache license header. All source files in this project should
include the standard Apache License 2.0 header at the beginning of the file,
consistent with other tool files like meta_tool.cpp and packed_file_tool.cpp.
##########
be/CMakeLists.txt:
##########
@@ -146,6 +146,15 @@ message(STATUS "build task executor simulator:
${BUILD_TASK_EXECUTOR_SIMULATOR}"
option(BUILD_FILE_CACHE_LRU_TOOL "ON for building file cache lru tool or OFF
for not" OFF)
message(STATUS "build file cache lru tool: ${BUILD_FILE_CACHE_LRU_TOOL}")
+if (DEFINED ENV{ENABLE_PAIMON_CPP})
+ set(ENABLE_PAIMON_CPP "$ENV{ENABLE_PAIMON_CPP}")
+endif()
+option(ENABLE_PAIMON_CPP "Enable Paimon C++ integration" OFF)
Review Comment:
Missing status message for ENABLE_PAIMON_CPP option. Following the pattern
of other build options in this file (BUILD_FS_BENCHMARK,
BUILD_TASK_EXECUTOR_SIMULATOR, BUILD_FILE_CACHE_LRU_TOOL), there should be a
message statement after the option declaration to log the configuration status,
similar to: message(STATUS "enable paimon cpp: ${ENABLE_PAIMON_CPP}")
```suggestion
option(ENABLE_PAIMON_CPP "Enable Paimon C++ integration" OFF)
message(STATUS "enable paimon cpp: ${ENABLE_PAIMON_CPP}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
