BiteTheDDDDt commented on code in PR #59816:
URL: https://github.com/apache/doris/pull/59816#discussion_r2688898226
##########
be/src/pipeline/exec/exchange_sink_buffer.h:
##########
@@ -136,7 +137,9 @@ struct RpcInstance {
InstanceLoId id;
// Mutex for thread-safe access to this instance's data
- std::unique_ptr<std::mutex> mutex;
+ // Using bthread mutex here because the rpc callback thread is a bthread
and it will
+ // try to hold the lock and access rpc instance.
+ std::unique_ptr<bthread::Mutex> mutex;
Review Comment:
注释里写一下用bthread::Mutex而不是std::mutex的原因？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
