dataroaring commented on PR #59896: URL: https://github.com/apache/doris/pull/59896#issuecomment-3752271147
### Code review Found 1 issue: 1. **Test/code mismatch for WHERE clause and jsonpaths validation** - The test file expects validation errors for jsonpaths (Test 4, Test 16) and WHERE clause (Test 7, Test 18), but the code does NOT implement these validations. The `validateFlexiblePartialUpdate()` methods only check for JSON format, fuzzy_parse, and COLUMNS specification. Either update the tests to reflect the new behavior (allowing jsonpaths and WHERE clause), or restore the validations if their removal was unintended. https://github.com/apache/doris/blob/3353055dfb7359250b4ffb09a7cf2a117478d70b/regression-test/suites/load_p0/routine_load/test_routine_load_flexible_partial_update.groovy#L273-L275 Test expects: ```groovy exception "Flexible partial update does not support jsonpaths" ``` But `validateFlexiblePartialUpdate()` in CreateRoutineLoadInfo.java does not check for jsonpaths: https://github.com/apache/doris/blob/3353055dfb7359250b4ffb09a7cf2a117478d70b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateRoutineLoadInfo.java#L449-L468 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
