mymeiyi commented on code in PR #59413:
URL: https://github.com/apache/doris/pull/59413#discussion_r2703092800


##########
cloud/src/meta-service/txn_lazy_committer.cpp:
##########
@@ -563,6 +573,15 @@ void make_committed_txn_visible(const std::string& 
instance_id, int64_t db_id, i
         LOG(INFO) << "remove running_key=" << hex(running_key) << " txn_id=" 
<< txn_id;
         txn->remove(running_key);
 
+        if (defer_deleting_pending_delete_bitmaps) {
+            for (int64_t table_id : txn_info.table_ids()) {
+                std::string lock_key =
+                        meta_delete_bitmap_update_lock_key({instance_id, 
table_id, -1});

Review Comment:
   should we check the lock_id == txn_id again to guarantee the correctness?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to