Copilot commented on code in PR #59906:
URL: https://github.com/apache/doris/pull/59906#discussion_r2703141734
##########
be/src/pipeline/exec/scan_operator.h:
##########
@@ -308,8 +308,7 @@ class ScanLocalState : public ScanLocalStateBase {
Status _get_topn_filters(RuntimeState* state);
- // Every time vconjunct_ctx_ptr is updated, the old ctx will be stored in
this vector
- // so that it will be destroyed uniformly at the end of the query.
+ // common push down exprs require FunctionContext and constant_str and it
managed by _stale_expr_ctxs
Review Comment:
The comment is misleading. Based on the code in scan_operator.cpp lines
287-296, `_stale_expr_ctxs` stores conjuncts that have been fully pushed down
as predicate columns (when new_root is null), not "common push down exprs".
Common push down exprs are stored in `_common_expr_ctxs_push_down`. The comment
should say something like "Stores conjuncts that have been fully pushed down to
storage layer as predicate columns. Kept alive to prevent FunctionContext and
constant strings from being freed prematurely."
```suggestion
// Stores conjuncts that have been fully pushed down to the storage
layer as predicate columns.
// These expr contexts are kept alive to prevent their FunctionContext
and constant strings
// from being freed prematurely.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
