Copilot commented on code in PR #60066:
URL: https://github.com/apache/doris/pull/60066#discussion_r2707502291
##########
be/src/common/signal_handler.h:
##########
@@ -244,9 +244,6 @@ void DumpTimeInfo() {
formatter.AppendString("-");
formatter.AppendUint64(query_id_lo, 16);
formatter.AppendString(" ***\n");
Review Comment:
After removing the output of `is_nereids` from this function, the
`is_nereids` thread_local variable (defined at line 56) and the
`set_signal_is_nereids()` function (defined at lines 449-451) are no longer
used anywhere in the codebase. Consider removing these as well to clean up the
dead code. Additionally, the call to `signal::set_signal_is_nereids()` in
`be/src/runtime/thread_context.cpp` (line 47) should also be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
