dataroaring commented on PR #59528: URL: https://github.com/apache/doris/pull/59528#issuecomment-3774194061
### Code review Found 2 issues: 1. **Configuration name mismatch**: Test uses `enable_only_warm_up_idx` but C++ code defines `file_cache_enable_only_warm_up_idx`. The test configuration will be silently ignored, causing the test to not actually test the new feature. https://github.com/apache/doris/blob/c9623157fc7aed86560f887b43e78827786c8e43/regression-test/suites/cloud_p0/cache/warm_up/test_warmup_table_docker.groovy#L29-L31 Compare with the config definition: https://github.com/apache/doris/blob/c9623157fc7aed86560f887b43e78827786c8e43/be/src/common/config.cpp#L1219-L1221 2. **Warmup completion tracking broken**: When `file_cache_enable_only_warm_up_idx=true`, segment downloads are skipped but `complete_rowset_segment_warmup()` is never called for those skipped segments. The warmup tracking expects all segments to be counted (`has_finished()` checks `num_segments_warmed_up >= num_segments`), so warmup jobs will hang indefinitely. https://github.com/apache/doris/blob/c9623157fc7aed86560f887b43e78827786c8e43/be/src/cloud/cloud_warm_up_manager.cpp#L249-L268 The callback containing `complete_rowset_segment_warmup()` is only executed when segment download runs. When segments are skipped (flag is true), the completion callback never executes, leaving the warmup state incomplete. --- Generated with [Claude Code](https://claude.ai/code) <sub>If this code review was useful, please react with :+1:. Otherwise, react with :-1:.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
