Copilot commented on code in PR #60042:
URL: https://github.com/apache/doris/pull/60042#discussion_r2711267404
##########
be/src/vec/exec/format/column_type_convert.h:
##########
@@ -615,7 +615,7 @@ class DateTimeToNumericConverter : public
ColumnTypeConverter {
}
size_t rows = from_col->size();
- auto& src_data = static_cast<const
SrcColumnType*>(from_col.get())->get_data();
+ const auto& src_data = static_cast<const
SrcColumnType*>(from_col.get())->get_data();
Review Comment:
The auto keyword is being changed to const auto&, which is good for avoiding
unnecessary copies. However, this change appears unrelated to the PR's stated
purpose of removing useless return type checks from unix_timestamp. Consider
moving this change to a separate commit or clarifying its relationship to the
main refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
