CalvinKirs commented on PR #59893:
URL: https://github.com/apache/doris/pull/59893#issuecomment-3782408567
@Sbaia H i，Sorry, after reviewing the Iceberg code, I realized we can’t
directly use the AWS credential chain because it `requires a create() or
create(Map) method in the .credentials-provider. `
```
/**
* Configure the AWS credentials provider used to create AWS clients. A
fully qualified concrete
* class with package that implements the {@link AwsCredentialsProvider}
interface is required.
*
* <p>Additionally, the implementation class must also have a create() or
create(Map) method
* implemented, which returns an instance of the class that provides aws
credentials provider.
*
* <p>Example:
*
client.credentials-provider=software.amazon.awssdk.auth.credentials.SystemPropertyCredentialsProvider
*
* <p>When set, the default client factory {@link
* org.apache.iceberg.aws.AwsClientFactories#defaultFactory()} and other
AWS client factory
* classes will use this provider to get AWS credentials provided instead
of reading the default
* credential chain to get AWS access credentials.
*/
public static final String CLIENT_CREDENTIALS_PROVIDER =
"client.credentials-provider";
```
So I removed that part.
At the same time, since we’ve always been using S3 parameters, I added a
check in FileIO to see if we can use the Role ARN. Could you help test the
latest code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
