liaoxin01 opened a new pull request, #60160:
URL: https://github.com/apache/doris/pull/60160
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
1. Use rs_meta.fs() instead of storage_resource.value()->fs in warm up
functions to support packed files. PackedFileSystem wrapper in rs_meta.fs()
handles the index_map lookup and reads from the correct packed file path with
proper offset.
Without this fix, warm up would try to directly open the segment/index
path which does not exist on S3 because the data is actually stored in a packed
file.
Fixed locations:
- CloudWarmUpManager::handle_jobs(): segment and inverted index download
- CloudInternalServiceImpl::warm_up_rowset(): segment and inverted index
download
2. Fix packed_file_manager to use correct TTL cache type when writing small
files to file cache. Previously it always used FileCacheType::NORMAL, causing
ttl_cache_size mismatch between source and target clusters during warm up.
Now expiration_time is passed through PackedAppendContext and used to set
the correct cache type (TTL when expiration_time > 0, NORMAL otherwise).
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
