morningman commented on code in PR #14084:
URL: https://github.com/apache/doris/pull/14084#discussion_r1022745480


##########
be/src/common/config.h:
##########
@@ -296,7 +296,7 @@ CONF_mInt32(generate_compaction_tasks_min_interval_ms, 
"10");
 
 // Compaction task number per disk.
 // Must be greater than 2, because Base compaction and Cumulative compaction 
have at least one thread each.
-CONF_mInt32(compaction_task_num_per_disk, "2");
+CONF_mInt32(compaction_task_num_per_disk, "10");

Review Comment:
   For SATA, is it too big?



##########
be/src/common/config.h:
##########
@@ -680,7 +680,7 @@ CONF_Int64(download_cache_buffer_size, "10485760");
 // so if there are too many segment in a rowset, the compaction process
 // will run out of memory.
 // When doing compaction, each segment may take at least 1MB buffer.
-CONF_mInt32(max_segment_num_per_rowset, "200");
+CONF_mInt32(max_segment_num_per_rowset, "1500");

Review Comment:
   I' m not sure if there are too many segments in a rowset, the query 
operation will cost too much memory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to