heguanhui commented on code in PR #60215:
URL: https://github.com/apache/doris/pull/60215#discussion_r2726663578
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowFunctionsCommand.java:
##########
@@ -223,10 +220,12 @@ protected ShowResultSet
handleShowFunctions(ConnectContext ctx, StmtExecutor exe
this.dbName = reAcquireDbName(ctx, dbName);
}
- if (!FunctionUtil.isGlobalFunction(type) &&
!Env.getCurrentEnv().getAccessManager()
- .checkDbPriv(ConnectContext.get(),
InternalCatalog.INTERNAL_CATALOG_NAME, dbName, PrivPredicate.SHOW)) {
-
ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
- ConnectContext.get().getQualifiedUser(), dbName);
+ if (!FunctionUtil.isGlobalFunction(type)) {
Review Comment:
show builtin functions command should not rely on db privileges, if we use
ShowFunctionsCommand to fullfil this function, user also can use show builtin
functions from db or show builtin functions in db, this is still not quite
suitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
