liaoxin01 opened a new pull request, #60284:
URL: https://github.com/apache/doris/pull/60284
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #60148
Problem Summary:
Problem:
When TabletStream is destroyed without pre_close() being called (e.g.,
on_idle_timeout scenario), the _flush_token destructor calls shutdown() which
triggers deadlock detection if called from the pool thread.
Root cause:
- on_idle_timeout() directly calls brpc::StreamClose() without calling
LoadStream::close()
- This triggers the destruction chain without calling pre_close() on
TabletStreams
- If flush tasks are still running, TabletStream may be destroyed in pool
thread
Solution:
- Add IndexStream::~IndexStream() to ensure wait_for_flush_tasks() is called
on all TabletStreams
- Add TabletStream::wait_for_flush_tasks() to wait for all flush tasks to
complete
- This ensures _flush_token is properly handled before TabletStream
destruction
- Revert #60148 (shared_from_this) as it is no longer needed
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
