linrrzqqq commented on code in PR #60170:
URL: https://github.com/apache/doris/pull/60170#discussion_r2736708831
##########
be/src/vec/functions/functions_geo.cpp:
##########
@@ -858,6 +858,189 @@ struct StAsBinary {
}
};
+struct StLength {
+ static constexpr auto NAME = "st_length";
+ static const size_t NUM_ARGS = 1;
+ using Type = DataTypeFloat64;
+ static Status execute(Block& block, const ColumnNumbers& arguments, size_t
result) {
+ DCHECK_EQ(arguments.size(), 1);
+ auto return_type = block.get_data_type(result);
+
+ auto col =
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto size = col->size();
+ auto res = ColumnFloat64::create();
+ res->reserve(size);
+ auto null_map = ColumnUInt8::create(size, 0);
+ auto& null_map_data = null_map->get_data();
+
+ std::unique_ptr<GeoShape> shape;
+ for (int row = 0; row < size; ++row) {
+ auto shape_value = col->get_data_at(row);
+ shape = GeoShape::from_encoded(shape_value.data, shape_value.size);
+ if (!shape) {
+ null_map_data[row] = 1;
+ res->insert_default();
+ continue;
+ }
+
+ double length = shape->Length();
+ res->insert_value(length);
+ }
+
+ block.replace_by_position(result,
+ ColumnNullable::create(std::move(res),
std::move(null_map)));
+ return Status::OK();
+ }
+};
+
+struct StGeometryType {
+ static constexpr auto NAME = "st_geometrytype";
+ static const size_t NUM_ARGS = 1;
+ using Type = DataTypeString;
+ static Status execute(Block& block, const ColumnNumbers& arguments, size_t
result) {
+ DCHECK_EQ(arguments.size(), 1);
+ auto return_type = block.get_data_type(result);
+
+ auto col =
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto size = col->size();
+ auto res = ColumnString::create();
+ auto null_map = ColumnUInt8::create(size, 0);
+ auto& null_map_data = null_map->get_data();
+
+ std::unique_ptr<GeoShape> shape;
+ for (int row = 0; row < size; ++row) {
+ auto shape_value = col->get_data_at(row);
+ shape = GeoShape::from_encoded(shape_value.data, shape_value.size);
+ if (!shape) {
+ null_map_data[row] = 1;
+ res->insert_default();
+ continue;
+ }
+
+ auto geo_type = shape->GeometryType();
+ res->insert_data(geo_type.data(), geo_type.size());
+ }
+
+ block.replace_by_position(result,
+ ColumnNullable::create(std::move(res),
std::move(null_map)));
+ return Status::OK();
+ }
+};
+
+struct StDistance {
+ static constexpr auto NAME = "st_distance";
+ static const size_t NUM_ARGS = 2;
+ using Type = DataTypeFloat64;
+
+ static Status execute(Block& block, const ColumnNumbers& arguments, size_t
result) {
+ DCHECK_EQ(arguments.size(), 2);
+ auto return_type = block.get_data_type(result);
+ const auto& [left_column, left_const] =
+ unpack_if_const(block.get_by_position(arguments[0]).column);
+ const auto& [right_column, right_const] =
+ unpack_if_const(block.get_by_position(arguments[1]).column);
+
+ const auto size = std::max(left_column->size(), right_column->size());
+
+ auto res = ColumnFloat64::create();
+ res->reserve(size);
+ auto null_map = ColumnUInt8::create(size, 0);
+ auto& null_map_data = null_map->get_data();
+
+ if (left_const) {
+ const_vector(left_column, right_column, res, null_map_data, size);
+ } else if (right_const) {
+ vector_const(left_column, right_column, res, null_map_data, size);
+ } else {
+ vector_vector(left_column, right_column, res, null_map_data, size);
+ }
+ block.replace_by_position(result,
+ ColumnNullable::create(std::move(res),
std::move(null_map)));
+ return Status::OK();
+ }
+
+ static bool decode_shape(const StringRef& value,
std::unique_ptr<GeoShape>& shape) {
+ shape = GeoShape::from_encoded(value.data, value.size);
+ return static_cast<bool>(shape);
+ }
+
+ static void loop_do(StringRef& lhs_value, StringRef& rhs_value,
+ std::vector<std::unique_ptr<GeoShape>>& shapes,
+ ColumnFloat64::MutablePtr& res, NullMap& null_map, int
row) {
+ StringRef* strs[2] = {&lhs_value, &rhs_value};
+ for (int i = 0; i < 2; ++i) {
+ if (!decode_shape(*strs[i], shapes[i])) {
+ null_map[row] = 1;
+ res->insert_default();
+ return;
+ }
+ }
+ res->insert_value(shapes[0]->Distance(shapes[1].get()));
Review Comment:
I see that the Distance function may return -1 (not now though), here we
should add a check for the error return value and it's best to marked as
`[[unlikely]]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
