CalvinKirs opened a new pull request, #60387:
URL: https://github.com/apache/doris/pull/60387
When an insert task is canceled during execution, the shared `ctx` object
may be set to null. Currently, after `command.runWithUpdateInfo(...)`, the code
directly accesses `ctx.getState()`. If `ctx` is null or its state is null, this
leads to a NullPointerException (NPE).
### Solution
- Cache the `ctx` reference to a local variable to avoid race conditions.
- Check both `ctx` and `ctx.getState()` for null before accessing.
- If the task was canceled or the state is null, safely return without
throwing an exception.
- Maintain existing behavior: if the task completes with a non-OK state,
still throw `JobException`.
### Impact
- Prevents NPE when a task is canceled during execution.
- Makes the insert task more robust in concurrent cancel scenarios.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
