This is an automated email from the ASF dual-hosted git repository.
englefly pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 22afe119fb0 [fix](parser) fix DELETE/UPDATE cannot resolve column when
table alias uses AS keyword
(#60335)
22afe119fb0 is described below
commit 22afe119fb00d26c6601044bc1ad48b800a8a6f5
Author: minghong <[email protected]>
AuthorDate: Sat Jan 31 13:34:11 2026 +0800
[fix](parser) fix DELETE/UPDATE cannot resolve column when table alias uses
AS keyword
(#60335)
### What problem does this PR solve?
example:
delete from d_table as t1
using d_table as t2
where t2.k2 = 2
and t1.k1 = t2.k1;
before this pr, parser will report error that cannot find k1 in ast1,
because ast1 is parsed as table alias.
---
.../doris/nereids/parser/LogicalPlanBuilder.java | 4 +-
.../deleteFromUsing/deleteFromUsing.groovy | 51 ++++++++++++++++++++++
2 files changed, 53 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java
index 578cd1f6908..bbca612ffad 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java
@@ -1964,7 +1964,7 @@ public class LogicalPlanBuilder extends
DorisParserBaseVisitor<Object> {
query = withFilter(query, Optional.ofNullable(ctx.whereClause()));
String tableAlias = null;
if (ctx.tableAlias().strictIdentifier() != null) {
- tableAlias = ctx.tableAlias().getText();
+ tableAlias = ctx.tableAlias().strictIdentifier().getText();
}
Optional<LogicalPlan> cte = Optional.empty();
if (ctx.cte() != null) {
@@ -1989,7 +1989,7 @@ public class LogicalPlanBuilder extends
DorisParserBaseVisitor<Object> {
);
String tableAlias = null;
if (ctx.tableAlias().strictIdentifier() != null) {
- tableAlias = ctx.tableAlias().getText();
+ tableAlias = ctx.tableAlias().strictIdentifier().getText();
}
Command deleteCommand;
diff --git
a/regression-test/suites/query_p0/deleteFromUsing/deleteFromUsing.groovy
b/regression-test/suites/query_p0/deleteFromUsing/deleteFromUsing.groovy
new file mode 100644
index 00000000000..a6fa8b63aca
--- /dev/null
+++ b/regression-test/suites/query_p0/deleteFromUsing/deleteFromUsing.groovy
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("deleteFromUsing") {
+ sql """ DROP TABLE IF EXISTS d_table; """
+
+ sql """
+ create table d_table(
+ k1 int null,
+ k2 int not null,
+ k3 bigint null,
+ k4 varchar(100) null
+ )
+ unique key (k1,k2,k3)
+ distributed BY hash(k1) buckets 3
+ properties("replication_num" = "1");
+ """
+
+ sql "insert into d_table select 1,1,1,'a';"
+ sql "insert into d_table select 2,2,2,'b';"
+
+
+ sql "set dry_run_query=true;"
+
+ // fix DELETE/UPDATE cannot resolve column when table alias uses AS
keyword
+
+ // When using 'DELETE FROM table AS t1', the tableAlias was incorrectly
+ // set to 'AS t1' instead of 't1', causing column resolution to fail
+ // in subqueries. Changed to use strictIdentifier().getText() to get
+ // only the identifier part.
+ sql """
+ delete from d_table as t1
+ using d_table as t2
+ where t2.k2 = 2
+ and t1.k1 = t2.k1;
+ """
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
