This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 34e239a8271 [imp](log) Clearly print the real path of the target file
when cannot be read (#60340)
34e239a8271 is described below
commit 34e239a82717ca25dcbd04acded62d656a38ac9f
Author: Yixuan Wang <[email protected]>
AuthorDate: Mon Feb 2 10:43:23 2026 +0800
[imp](log) Clearly print the real path of the target file when cannot be
read (#60340)
The previous implementation will output an empty string.
---
be/src/io/fs/s3_obj_storage_client.cpp | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/be/src/io/fs/s3_obj_storage_client.cpp
b/be/src/io/fs/s3_obj_storage_client.cpp
index cec94ac3be7..1b8bf7b473c 100644
--- a/be/src/io/fs/s3_obj_storage_client.cpp
+++ b/be/src/io/fs/s3_obj_storage_client.cpp
@@ -324,9 +324,8 @@ ObjectStorageResponse S3ObjStorageClient::get_object(const
ObjectStoragePathOpti
SCOPED_BVAR_LATENCY(s3_bvar::s3_get_latency);
auto outcome = s3_get_rate_limit([&]() { return
_client->GetObject(request); });
if (!outcome.IsSuccess()) {
- return {convert_to_obj_response(
- s3fs_error(outcome.GetError(),
- fmt::format("failed to read from {}",
opts.path.native()))),
+ return {convert_to_obj_response(s3fs_error(
+ outcome.GetError(), fmt::format("failed to read from
{}", opts.key))),
static_cast<int>(outcome.GetError().GetResponseCode()),
outcome.GetError().GetRequestId()};
}
@@ -335,8 +334,8 @@ ObjectStorageResponse S3ObjStorageClient::get_object(const
ObjectStoragePathOpti
SYNC_POINT_CALLBACK("s3_obj_storage_client::get_object", size_return);
if (*size_return != bytes_read) {
return {convert_to_obj_response(Status::InternalError(
- "failed to read from {}(bytes read: {}, bytes req: {}),
request_id: {}",
- opts.path.native(), *size_return, bytes_read,
outcome.GetResult().GetRequestId()))};
+ "failed to read from {}(bytes read: {}, bytes req: {}),
request_id: {}", opts.key,
+ *size_return, bytes_read,
outcome.GetResult().GetRequestId()))};
}
return ObjectStorageResponse::OK();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
