Copilot commented on code in PR #60412:
URL: https://github.com/apache/doris/pull/60412#discussion_r2753976972
##########
regression-test/suites/query_p0/sql_functions/string_functions/test_string_all.groovy:
##########
@@ -753,6 +753,18 @@ suite("string_functions_all") {
testFoldConst("SELECT soundex('R@b-e123rt'), soundex('Robert');")
// SOUNDEX tests with non-ASCII characters - Skipped (not supported)
+ // LEVENSHTEIN tests
+ qt_levenshtein_331 "SELECT levenshtein('', ''), levenshtein('kitten',
'sitting'), levenshtein('flaw', 'lawn'), levenshtein('你好', '你们'),
levenshtein('数据库', '数据');"
+ testFoldConst("SELECT levenshtein('', ''), levenshtein('kitten',
'sitting'), levenshtein('flaw', 'lawn'), levenshtein('你好', '你们'),
levenshtein('数据库', '数据');")
+ qt_levenshtein_332 "SELECT levenshtein('abc', 'abc'), levenshtein('abc',
''), levenshtein('', 'abc'), levenshtein(NULL, 'abc'), levenshtein('abc',
NULL);"
+ testFoldConst("SELECT levenshtein('abc', 'abc'), levenshtein('abc', ''),
levenshtein('', 'abc'), levenshtein(NULL, 'abc'), levenshtein('abc', NULL);")
+
+ // HAMMING_DISTANCE tests
+ qt_hamming_distance_3331 "SELECT hamming_distance('', ''),
hamming_distance('abc', 'abc'), hamming_distance('abc', 'abd'),
hamming_distance('你好', '你们');"
+ testFoldConst("SELECT hamming_distance('', ''), hamming_distance('abc',
'abc'), hamming_distance('abc', 'abd'), hamming_distance('你好', '你们');")
Review Comment:
Test identifier 'qt_hamming_distance_3331' has inconsistent numbering (3331
instead of 333). Should be 'qt_hamming_distance_333' to match the pattern used
for other functions like 'qt_space_333'.
```suggestion
qt_hamming_distance_333 "SELECT hamming_distance('', ''),
hamming_distance('abc', 'abc'), hamming_distance('abc', 'abd'),
hamming_distance('你好', '你们');"
testFoldConst("SELECT hamming_distance('', ''), hamming_distance('abc',
'abc'), hamming_distance('abc', 'abd'), hamming_distance('你好', '你们');"
```
##########
regression-test/suites/query_p0/sql_functions/string_functions/test_string_all.groovy:
##########
@@ -753,6 +753,18 @@ suite("string_functions_all") {
testFoldConst("SELECT soundex('R@b-e123rt'), soundex('Robert');")
// SOUNDEX tests with non-ASCII characters - Skipped (not supported)
+ // LEVENSHTEIN tests
+ qt_levenshtein_331 "SELECT levenshtein('', ''), levenshtein('kitten',
'sitting'), levenshtein('flaw', 'lawn'), levenshtein('你好', '你们'),
levenshtein('数据库', '数据');"
+ testFoldConst("SELECT levenshtein('', ''), levenshtein('kitten',
'sitting'), levenshtein('flaw', 'lawn'), levenshtein('你好', '你们'),
levenshtein('数据库', '数据');")
+ qt_levenshtein_332 "SELECT levenshtein('abc', 'abc'), levenshtein('abc',
''), levenshtein('', 'abc'), levenshtein(NULL, 'abc'), levenshtein('abc',
NULL);"
+ testFoldConst("SELECT levenshtein('abc', 'abc'), levenshtein('abc', ''),
levenshtein('', 'abc'), levenshtein(NULL, 'abc'), levenshtein('abc', NULL);")
+
+ // HAMMING_DISTANCE tests
+ qt_hamming_distance_3331 "SELECT hamming_distance('', ''),
hamming_distance('abc', 'abc'), hamming_distance('abc', 'abd'),
hamming_distance('你好', '你们');"
+ testFoldConst("SELECT hamming_distance('', ''), hamming_distance('abc',
'abc'), hamming_distance('abc', 'abd'), hamming_distance('你好', '你们');")
+ qt_hamming_distance_3332 "SELECT hamming_distance('abc', 'abc'),
hamming_distance(NULL, 'abc'), hamming_distance('abc', NULL);"
Review Comment:
Test identifier 'qt_hamming_distance_3332' has inconsistent numbering (3332
instead of 334). Should be 'qt_hamming_distance_334' to follow the sequential
pattern.
```suggestion
qt_hamming_distance_334 "SELECT hamming_distance('abc', 'abc'),
hamming_distance(NULL, 'abc'), hamming_distance('abc', NULL);"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
