JNSimba commented on code in PR #351:
URL:
https://github.com/apache/doris-spark-connector/pull/351#discussion_r2757940529
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/read/RowBatch.java:
##########
@@ -145,19 +145,24 @@ public RowBatch(ArrowReader reader, Schema schema,
Boolean datetimeJava8ApiEnabl
private void readBatch(VectorSchemaRoot root) throws DorisException {
fieldVectors = root.getFieldVectors();
- if (fieldVectors.size() > schema.size()) {
- logger.error("Data schema size '{}' should not be bigger than
arrow field size '{}'.",
- schema.size(), fieldVectors.size());
+ if (fieldVectors.size() < schema.size()) {
+ logger.error("Arrow field size '{}' is less than data schema size
'{}'.",
+ fieldVectors.size(), schema.size());
Review Comment:
I remember there was a version of Doris where the schema would return
`delete_sign`, but the data wasn't actually there. Could this change cause a
problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
