924060929 commented on code in PR #14380:
URL: https://github.com/apache/doris/pull/14380#discussion_r1026273470
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/AggregateFunction.java:
##########
@@ -183,6 +183,30 @@ public AggregateFunction(FunctionName fnName, List<Type>
argTypes,
returnsNonNullOnEmpty = false;
}
+ public AggregateFunction(FunctionName fnName, List<Type> argTypes,
+ Type retType, Type intermediateType, boolean hasVarArgs,
+ URI location, String updateFnSymbol, String initFnSymbol,
+ String serializeFnSymbol, String mergeFnSymbol, String
getValueFnSymbol,
+ String removeFnSymbol, String finalizeFnSymbol, boolean
ignoresDistinct,
+ boolean isAnalyticFn, boolean returnsNonNullOnEmpty,
TFunctionBinaryType binaryType,
+ boolean userVisible, boolean vectorized, NullableMode
nullableMode) {
+ // only `count` is always not nullable, other aggregate function is
always nullable
+ super(0, fnName, argTypes, retType, hasVarArgs, binaryType,
userVisible, vectorized, nullableMode);
+ setLocation(location);
+ this.intermediateType = (intermediateType.equals(retType)) ? null :
intermediateType;
+ this.updateFnSymbol = updateFnSymbol;
+ this.initFnSymbol = initFnSymbol;
+ this.serializeFnSymbol = serializeFnSymbol;
+ this.mergeFnSymbol = mergeFnSymbol;
+ this.getValueFnSymbol = getValueFnSymbol;
+ this.removeFnSymbol = removeFnSymbol;
+ this.finalizeFnSymbol = finalizeFnSymbol;
Review Comment:
thrift message has some required field, so we should set to it.
In nereids, this, this fields usually are null or empty string, we set this
fields in ExpressionTranslator.visitAggregateFunction()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
