jacktengg commented on code in PR #60393:
URL: https://github.com/apache/doris/pull/60393#discussion_r2766652917
##########
be/src/vec/data_types/serde/data_type_decimal_serde.cpp:
##########
@@ -125,6 +125,22 @@ Status DataTypeDecimalSerDe<T>::from_string(StringRef&
str, IColumn& column,
return Status::OK();
}
+template <PrimitiveType T>
+Status DataTypeDecimalSerDe<T>::from_string(const std::string& str, Field&
field,
+ const FormatOptions& options)
const {
+ FieldType to;
+ CastParameters params;
+ params.is_strict = false;
+
+ auto arg_precision = static_cast<UInt32>(precision);
+
+ if (!CastToDecimal::from_string(StringRef(str), to, arg_precision, 0,
params)) {
Review Comment:
Should use scale?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
