adonis0147 commented on PR #14410: URL: https://github.com/apache/doris/pull/14410#issuecomment-1320907944
> > > @adonis0147 In `mem_info.cpp:193`, when it is __APPLE_, there is an empty `refresh_proc_meminfo`, does this not work? > > > > > > Hi @xinyiZzz , the error was caused by [be/src/service/doris_main.cpp:505](https://github.com/apache/doris/blob/master/be/src/service/doris_main.cpp#L505). This line references a function which doesn't have a definition. > > Thks reply @adonis0147 , I mean `refresh_proc_meminfo` defines an empty function in `mem_info.cpp:193`. Because don't want mac to call the `refresh_allocator_mem` method. It seems that `refresh_proc_meminfo` doesn't call `refresh_allocator_mem` and the implementation of `refresh_allocator_mem` just interacts with `jemalloc` or `tcmalloc` and no platform specific logic is introduced. I don't think we need to introduce a new special definition like `refresh_proc_meminfo`. More special handlings will make the maintenance job more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
