zhiqiang-hhhh opened a new pull request, #60564:
URL: https://github.com/apache/doris/pull/60564
### What problem does this PR solve?
[fix](vector-index) Handle nullable literal gracefully in ANN range search
Refactor `prepare_ann_range_search` to check the distance function first,
then validate the literal. This prevents crashes when the right-side literal
has a nullable type.
Previously, when a nullable literal (e.g., from a scalar subquery result)
was passed to ANN range search:
- Debug mode: threw an exception inside #ifndef NDEBUG block
- Release mode: crashed in assert_cast<ColumnFloat64*> because the actual
column type was ColumnNullable
Now the function gracefully marks the expression as unsuitable for ANN
index optimization instead of crashing, allowing the query to fall back
to normal execution path.
Changes:
1. Reorder validation: check distance function before checking literal
2. Replace debug-only exception with mark_unsuitable() for nullable literals
3. Add consistency check between Cast expression and literal type
4. Improve code structure with clear step comments
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
