xiaokang commented on code in PR #14431:
URL: https://github.com/apache/doris/pull/14431#discussion_r1027504737
##########
thirdparty/build-thirdparty.sh:
##########
@@ -817,9 +817,10 @@ build_cyrus_sasl() {
check_if_source_exist "${CYRUS_SASL_SOURCE}"
cd "${TP_SOURCE_DIR}/${CYRUS_SASL_SOURCE}"
- CPPFLAGS="-I${TP_INCLUDE_DIR}" \
+ CFLAGS="-fPIC" \
+ CPPFLAGS="-I${TP_INCLUDE_DIR}" \
LDFLAGS="-L${TP_LIB_DIR}" \
- ./configure --prefix="${TP_INSTALL_DIR}" --enable-static
--enable-shared=no --with-openssl="${TP_INSTALL_DIR}" --with-pic
+ ./configure --prefix="${TP_INSTALL_DIR}" --enable-static
--enable-shared=no --with-openssl="${TP_INSTALL_DIR}" --with-pic
--enable-gssapi="${TP_INSTALL_DIR}" --with-gss_impl=mit --with-dblib=none
Review Comment:
is '--with-dblib=none' needed?
##########
thirdparty/build-thirdparty.sh:
##########
@@ -836,6 +837,10 @@ build_librdkafka() {
cd "${TP_SOURCE_DIR}/${LIBRDKAFKA_SOURCE}"
+ # NOTE(amos): librdkafka uses a weird autoconf variant (mklove) which
doesn't allow extending PKG_CONFIG with spaces in cmd.
+ # As a result, we use a patch to hard code "--static" into PKG_CONFIG
instead.
+ # PKG_CONFIG="pkg-config --static"
+
Review Comment:
do we need to add --enable-gssapi for build_librdkafka?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
