jacktengg commented on code in PR #60367:
URL: https://github.com/apache/doris/pull/60367#discussion_r2781240175
##########
be/src/pipeline/dependency.cpp:
##########
@@ -319,20 +319,31 @@ Status AggSharedState::reset_hash_table() {
}
void PartitionedAggSharedState::init_spill_params(size_t
spill_partition_count) {
- partition_count = spill_partition_count;
+ // PartitionedAgg uses hierarchical spill partitioning with fixed 8-way
fanout per level.
+ // Keep the API but ignore spill_partition_count for fanout.
+ //
+ // The existing RuntimeState::spill_aggregation_partition_count() was
originally used to decide
+ // the number of single-level partitions. With multi-level partitioning,
fanout must be stable
+ // across sink/source and across split levels, so we pin it to
kSpillFanout=8 (same as join).
+ partition_count = kSpillFanout;
max_partition_index = partition_count - 1;
Review Comment:
max_partition_index is useless now, can delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
