Copilot commented on code in PR #60618:
URL: https://github.com/apache/doris/pull/60618#discussion_r2781703327
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -2089,6 +2089,8 @@ Status PipelineFragmentContext::set_to_rerun() {
Status PipelineFragmentContext::rebuild(ThreadPool* thread_pool) {
_submitted = false;
_is_fragment_instance_closed = false;
+ // _require_bucket_distribution may be set to true to affect the building
of pipeline with local shuffle
+ _require_bucket_distribution = false;
return _build_and_prepare_full_pipeline(thread_pool);
Review Comment:
This change fixes state carried across `rebuild()`, but there doesn’t appear
to be any unit test coverage for the rerun/rebuild path (e.g., a rec-CTE round
triggering `wait/release/rebuild/submit`). Consider adding a BE pipeline unit
test that exercises at least two rebuild cycles and asserts the pipeline build
outcome isn’t affected by stale `_require_bucket_distribution` from the prior
build (e.g., local shuffle/bucket distribution decisions differ between rounds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
