Copilot commented on code in PR #3371: URL: https://github.com/apache/doris-website/pull/3371#discussion_r2789664820
########## versioned_docs/version-3.x/benchmark/tpch.md: ########## @@ -12,7 +12,7 @@ TPC-H is a decision support benchmark (Decision Support Benchmark), which consis This document mainly introduces the performance of Doris on the TPC-H 1000G test set. -On 22 queries on the TPC-H standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Coupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x +On 22 queries on the TPC-H standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Decoupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x Review Comment: After switching the doc to “Compute-Storage Decoupled Mode”, the later “Environmental Preparation” section still points readers to the integrated-storage-compute deployment doc. Please update either the stated benchmark mode or the referenced deployment instructions so they’re consistent (decoupled benchmarks should link to the compute-storage decoupled deployment docs). ########## versioned_docs/version-3.x/benchmark/tpcds.md: ########## @@ -14,7 +14,7 @@ The design goal of TPC-DS is to simulate complex decision support workloads in t This document mainly introduces the performance of Doris on the TPC-DS 1000G test set. -On 99 queries on the TPC-DS standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Coupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x +On 99 queries on the TPC-DS standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Decoupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x Review Comment: After switching the doc to “Compute-Storage Decoupled Mode”, the later “Environmental Preparation” section still points readers to the integrated-storage-compute deployment doc. Please update either the stated benchmark mode or the referenced deployment instructions so they’re consistent (decoupled benchmarks should link to the compute-storage decoupled deployment docs). ########## versioned_docs/version-3.x/benchmark/tpcds.md: ########## @@ -14,7 +14,7 @@ The design goal of TPC-DS is to simulate complex decision support workloads in t This document mainly introduces the performance of Doris on the TPC-DS 1000G test set. -On 99 queries on the TPC-DS standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Coupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x +On 99 queries on the TPC-DS standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Decoupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x Review Comment: This sentence now says the 3.0.3-rc03 run is in “Compute-Storage Decoupled Mode”, but then immediately refers to “the integrated storage and computing mode in version 3.x”. That wording is contradictory/confusing after the mode change; please rephrase to consistently describe the decoupled mode and clarify what is being used as the baseline (e.g., 2.1.x integrated/coupled). Also consider ending the sentence with a period. ```suggestion For 99 queries on the TPC-DS standard test data set, we conducted a comparison test between Apache Doris 3.0.3-rc03 running in Compute-Storage Decoupled Mode and Apache Doris 2.1.7-rc03 running in the traditional integrated storage-compute mode, with the 2.1.x integrated mode used as the performance baseline for earlier 3.x integrated-mode results. ``` ########## versioned_docs/version-3.x/benchmark/tpch.md: ########## @@ -12,7 +12,7 @@ TPC-H is a decision support benchmark (Decision Support Benchmark), which consis This document mainly introduces the performance of Doris on the TPC-H 1000G test set. -On 22 queries on the TPC-H standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Coupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x +On 22 queries on the TPC-H standard test data set, we conducted a comparison test based on Apache Doris 3.0.3-rc03 (Compute-Storage Decoupled Mode) and Apache Doris 2.1.7-rc03 versions. The performance of the integrated storage and computing mode in version 3.x is based on version 2.1.x Review Comment: This sentence now says the 3.0.3-rc03 run is in “Compute-Storage Decoupled Mode”, but then immediately refers to “the integrated storage and computing mode in version 3.x”. That wording is contradictory/confusing after the mode change; please rephrase to consistently describe the decoupled mode and clarify what is being used as the baseline (e.g., 2.1.x integrated/coupled). Also consider ending the sentence with a period. ```suggestion On 22 queries on the TPC-H standard test data set, we conducted a comparison test between Apache Doris 3.0.3-rc03 in compute-storage decoupled mode and Apache Doris 2.1.7-rc03 in integrated storage-compute mode. The performance of the integrated storage-compute architecture in the 3.x series uses Apache Doris 2.1.x (integrated mode) as the baseline. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
