shuke987 opened a new pull request, #60721:
URL: https://github.com/apache/doris/pull/60721
…pped
### What problem does this PR solve?
BinlogConfigCache maintains two internal maps (dbTableBinlogEnableMap and
tableTypeMap) that cache BinlogConfig and table type info by db/table ID. These
caches are populated lazily when binlog-related operations query a table or
database for the first time.
However, when a table or database is dropped, BinlogManager.removeTable()
and removeDB() only clean up dbBinlogMap (the binlog data itself) but never
call binlogConfigCache.remove() to evict the corresponding cache entries.
Since each newly created table gets a globally incrementing ID, dropped
table entries are never overwritten — the cache grows without bound.
Reproduction
Run p0 regression tests in a loop (create tables → run tests → DROP all
databases). After 12 rounds:
BinlogConfig instances: 32,213 → 158,744 (+392.8%), strictly increasing
every round
dbTableBinlogEnableMap accumulated 105,936 entries (backing array expanded
to 262,144 slots, retained ~22MB)
Heap dump reference chain:
Env (serving)
→ BinlogManager
→ BinlogConfigCache
→ dbTableBinlogEnableMap (HashMap, 105,936 entries)
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
