Copilot commented on code in PR #60735:
URL: https://github.com/apache/doris/pull/60735#discussion_r2802270814
##########
be/test/util/crc32c_test.cpp:
##########
@@ -75,3 +79,400 @@ TEST(CRC, Extend) {
}
} // namespace doris
+
+namespace doris {
+
+// Helper: compute crc32c via crc32c::Crc32c for a value of type T
+template <typename T>
+uint32_t crc32c_reference(const T& value, uint32_t seed) {
+ return crc32c::Extend(seed, reinterpret_cast<const uint8_t*>(&value),
sizeof(T));
+}
+
+// Helper: compute zlib crc32 for a value of type T
+template <typename T>
+uint32_t zlib_crc32_reference(const T& value, uint32_t seed) {
+ return HashUtil::zlib_crc_hash(&value, sizeof(T), seed);
+}
+
+/*
+todo: fix those caeses when we have new release verseion do not consider the
compatibility issue
Review Comment:
Spelling error: "caeses" should be "cases" and "verseion" should be "version"
```suggestion
todo: fix those cases when we have a new release version; do not consider
the compatibility issue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]