caiconghui commented on code in PR #59391:
URL: https://github.com/apache/doris/pull/59391#discussion_r2807247498


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java:
##########
@@ -1314,7 +1315,8 @@ public static Expression 
processComparisonPredicate(ComparisonPredicate comparis
         if (GlobalVariable.enableNewTypeCoercionBehavior) {
             commonType = findWiderTypeForTwo(left.getDataType(), 
right.getDataType(), false, false);
         } else {
-            commonType = findWiderTypeForTwoForComparison(left.getDataType(), 
right.getDataType(), false);
+            commonType = findWiderTypeForTwoForComparison(left.getDataType(), 
right.getDataType(),
+                    comparisonPredicate instanceof EqualTo);

Review Comment:
   judge that string equal to int both cast to double is ok?  which engine we 
refer to?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to