airborne12 commented on PR #60761: URL: https://github.com/apache/doris/pull/60761#issuecomment-3901545437
### Code review Found 1 issue: 1. **Privilege regression in BackendsAction**: The `/api/backends` endpoint previously required only `SELECT` privilege on `information_schema` (set intentionally in PR #50140 for Spark/Flink connector compatibility). This PR changes it to require `ADMIN` privilege via `checkAdminAuth()`, which will break Spark/Flink connectors that rely on this endpoint without admin access. The class Javadoc at line 42 still says "Mainly used for flink/spark connector" and line 43 says "It only requires password, no auth check", contradicting the new `ADMIN` requirement. https://github.com/apache/doris/blob/b1e8a592eef1abd4a2475cb709f84afe5003d479/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/BackendsAction.java#L67-L72 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
