deardeng opened a new pull request, #60805:
URL: https://github.com/apache/doris/pull/60805
Problem
SHOW TABLET DIAGNOSIS reports local-storage style errors in cloud
(storage-compute separated) deployments. In cloud mode, replica version in FE
is not a reliable per-backend data freshness signal, and backend disk pressure
does not directly represent object-storage write availability.
Root cause
Diagnoser applied the same checks for both local and cloud modes:
- ReplicaBackendStatus always evaluated be.diskExceedLimit()
- ReplicaVersionStatus always required replica.version == partition visible
version (and checked lastFailedVersion)
These checks are valid for local replicas but can produce false positives in
cloud mode.
Change
- Added cloud-mode guard via Config.isCloudMode() in Diagnoser.
- In cloud mode, skip disk-exceed-limit check when building
ReplicaBackendStatus.
- In cloud mode, skip replica-version equality and last-failed-version
checks when building ReplicaVersionStatus.
- Kept backend liveness/availability checks
(exist/alive/decommission/load/query) unchanged.
- Added regression test testDiagnoseTabletCloudModeSkipDiskAndVersionCheck
in TabletReplicaTooSlowTest:
- creates a tablet with 3 replicas
- forces local-mode disk-exceed and version mismatch and verifies both
statuses report errors
- flips to cloud mode and verifies ReplicaBackendStatus and
ReplicaVersionStatus both become OK
- restores global config and backend disk state in finally block to avoid
side effects
Behavioral impact
This removes cloud-mode false alarms for
ReplicaBackendStatus/ReplicaVersionStatus while preserving meaningful backend
health diagnostics and existing local-mode semantics.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
