XieJiann commented on code in PR #14485:
URL: https://github.com/apache/doris/pull/14485#discussion_r1031010394


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -48,12 +49,11 @@ public class Group {
 
     private final List<GroupExpression> logicalExpressions = 
Lists.newArrayList();
     private final List<GroupExpression> physicalExpressions = 
Lists.newArrayList();
-    private LogicalProperties logicalProperties;
-
     // Map of cost lower bounds
     // Map required plan props to cost lower bound of corresponding plan
     private final Map<PhysicalProperties, Pair<Double, GroupExpression>> 
lowestCostPlans = Maps.newHashMap();
-
+    private LogicalProperties logicalProperties;
+    private double costLowerBound = -1;

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
         return children.get(i);
     }
 
+    public void setChild(int i, Group group) {
+        children.set(i, group);

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
         return children.get(i);
     }
 
+    public void setChild(int i, Group group) {
+        children.set(i, group);
+    }
+
+    public int childrenSize() {
+        return children.size();
+    }
+

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to