morningman commented on code in PR #59984:
URL: https://github.com/apache/doris/pull/59984#discussion_r2869293860


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalUtil.java:
##########
@@ -80,4 +90,124 @@ public static void initSchemaInfo(TFileScanRangeParams 
params, Long schemaId, Li
         tSchema.setRootField(getExternalSchema(columns));
         params.addToHistorySchemaInfo(tSchema);
     }
+
+
+    /**
+     * Initialize schema info based on SlotDescriptors, only including columns 
that are actually needed.
+     * For nested columns, only include sub-columns that are accessed 
according to pruned type.
+     *
+     * @param params TFileScanRangeParams to fill
+     * @param schemaId Schema ID
+     * @param slots List of SlotDescriptors that are actually needed
+     * @param nameMapping NameMapping from Iceberg table properties (can be 
null and empty.)
+     */
+    public static void initSchemaInfoForPrunedColumn(TFileScanRangeParams 
params, Long schemaId,

Review Comment:
   Add Unit test for `initSchemaInfoForPrunedColumn` and 
`getExternalSchemaForPrunedColumn`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to