CalvinKirs opened a new pull request, #60958:
URL: https://github.com/apache/doris/pull/60958
#60648
getMinPipelineExecutorSize in cloud paths implicitly depended on
ConnectContext, which caused two issues:
Unstable behavior when no thread-local context is available (e.g.
internal/async paths). Unclear API semantics since callers could not explicitly
specify the target cluster. This PR makes the API explicit by requiring
clusterName.
What Changed
Removed the no-arg getMinPipelineExecutorSize() API and kept only:
getMinPipelineExecutorSize(String clusterName). Unified SystemInfoService and
CloudSystemInfoService implementations to the string-arg API. Updated
SessionVariable#getParallelExecInstanceNum() to call the string-arg API, with
cluster resolved from session/auth information (instead of directly depending
on ConnectContext). Added synchronization in ConnectContext:
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
