cambyzju opened a new pull request, #14550: URL: https://github.com/apache/doris/pull/14550
# Proposed changes Issue Number: close #xxx ## Problem summary Problem desc: While we call `SELECT xxx INTO OUTFILE`, if we output data file success, we also write an empty `SUCCESS` file. But now the problem is: 1. if we write data file failed, we also write out an empty `SUCCESS` file; 2. if we write data file success, we write out the empty `SUCCESS` file twice; Why the problem: After https://github.com/apache/doris/pull/5489, we refractor _close_file_writer, but not change the caller. So we will create `SUCCESS` file once inside `close` function, and the other call while we deconstruct `FileResultWriter`. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 4. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 5. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 6. Does it need to update dependencies: - [ ] Yes - [ ] No 7. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [[email protected]](mailto:[email protected]) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
