BiteTheDDDDt commented on code in PR #60812:
URL: https://github.com/apache/doris/pull/60812#discussion_r2882363305
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -674,6 +678,18 @@ void
FragmentMgr::remove_pipeline_context(std::pair<TUniqueId, int> key) {
}
void FragmentMgr::remove_query_context(const TUniqueId& key) {
+ // Clean up any saved rerunnable params for this query to avoid memory
leaks.
+ // This covers both cancel and normal destruction paths.
+ {
+ std::lock_guard<std::mutex> lk(_rerunnable_params_lock);
+ for (auto it = _rerunnable_params_map.begin(); it !=
_rerunnable_params_map.end();) {
+ if (it->first.first == key) {
+ it = _rerunnable_params_map.erase(it);
+ } else {
+ ++it;
Review Comment:
外层保证了PFC不被析构，所以query ctx也不会被析构
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
