linrrzqqq commented on code in PR #60192:
URL: https://github.com/apache/doris/pull/60192#discussion_r2901140220
##########
be/src/vec/functions/array/function_array_combinations.cpp:
##########
@@ -60,6 +60,15 @@ class FunctionArrayCombinations : public IFunction {
auto array = block.get_by_position(arguments[0]).column;
ColumnPtr num = block.get_by_position(arguments[1]).column;
+ const auto* nullable_num =
check_and_get_column<ColumnNullable>(num.get());
+ if (nullable_num != nullptr && nullable_num->is_null_at(0)) {
+ ColumnPtr null_col =
+
ColumnNullable::create(block.get_by_position(result).type->create_column(),
+
ColumnUInt8::create(input_rows_count, 1));
+ block.replace_by_position(result, std::move(null_col));
+ return Status::OK();
+ }
+
Review Comment:
no need to do additional process here, if the function
`use_default_implementation_for_nulls` returns true(default), it will be
processed automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
