sahildevgon commented on PR #60777:
URL: https://github.com/apache/doris/pull/60777#issuecomment-4025322413
hi @morningman ,
Reg. point 1. [Critical] Split Unrelated Changes into Separate PRs :
- I have opened a New PR for the bug fix :
https://github.com/apache/doris/pull/61145 (Under review).
Reg. points 2,3,4,6 :
- I have posted new commits to align the changes with your review comments.
Reg. point 5. [Low] Consider Using Getter Methods for Field Access.
- All 17 field accesses in MetricRepo.java use direct field access — the
existing TCP fields (tcpRetransSegs, tcpInErrs,
etc.) and memory fields (memTotal, memFree, etc.) all follow the same
pattern.
- Introducing getters only for the new CPU fields would create inconsistency
within the same class.
- If you suggest I can post a separate PR for introducing getters for all
fields.
PS: The build of this PR might fail until we have the [Fix] PR :
https://github.com/apache/doris/pull/61145. (For which i am following up on
separate thread)
PTAL and requesting further review.
thanks,
Sahil Devgon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
