kaka11chen opened a new pull request, #61170:
URL: https://github.com/apache/doris/pull/61170
### What problem does this PR solve?
Problem Summary:
### Release note
Multiple test files defined different MockFileReader classes with the same
fully-qualified name doris::MockFileReader but different member layouts and
sizes (96 bytes vs 64 bytes). When linked into the single monolithic
doris_be_test binary, the linker would deduplicate symbols and arbitrarily pick
one version's template instantiations (e.g., make_shared, destructor), causing
size mismatches at runtime. This resulted in ASAN errors:
- heap-buffer-overflow: allocating 80 bytes but writing 96 bytes
- new-delete-type-mismatch: allocated 96 bytes, deallocated 64 bytes The ODR
conflict was exposed after #61142 removed the vectorized namespace, which moved
orc_file_reader_test.cpp's MockFileReader into namespace doris, colliding with
file_meta_cache_test.cpp's MockFileReader in the same namespace.
Fix: Wrap each MockFileReader class in an anonymous namespace to give them
internal linkage, ensuring each translation unit uses its own independent
symbols.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
