github-actions[bot] commented on code in PR #61177:
URL: https://github.com/apache/doris/pull/61177#discussion_r2910225482
##########
regression-test/suites/point_query_p0/test_short_circuit_project.groovy:
##########
@@ -0,0 +1,322 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
Review Comment:
**Minor (style):** Per the regression test coding standard: "For ordinary
single test tables, do not use `def tableName` form; instead hardcode your
table name in all SQL." Both `tableName` and `extTable` are used as variables
here. Consider hardcoding the table names directly in the SQL statements.
This is a minor style nit and does not affect correctness.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -739,6 +740,21 @@ public List<Expr> getProjectList() {
return projectList;
Review Comment:
**Minor (robustness):** The `getPointQueryProjectList()` method iterates
`intermediateProjectListList` by index and accesses
`intermediateOutputTupleDescList` at the same index. While the current codebase
guarantees these two lists are always populated in pairs (verified in
`PhysicalPlanTranslator.visitPhysicalProject()`), a `Preconditions.checkState`
at the top of this method asserting `intermediateOutputTupleDescList.size() ==
intermediateProjectListList.size()` would make the invariant explicit and
self-documenting, consistent with the `Preconditions.checkState` already used
in `createPointQueryProjectionSmap()` for the slot/expr size invariant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
