csun5285 opened a new pull request, #61189:
URL: https://github.com/apache/doris/pull/61189
1. JsonBinaryValueTest.TestValidation: fix assertions to match parser
behavior
- Empty string and non-JSON text ('abc') correctly return error since
c3e418b8 refactored JsonbParser, update EXPECT_TRUE to EXPECT_FALSE
- Scalar JSON values ('1', 'null', 'false') parse successfully, keep
EXPECT_TRUE
2. AcceptNullPredicateTest: fix ODR violation with MockIndexIterator
- MockIndexIterator was defined in both accept_null_predicate_test.cpp
and function_ip_test.cpp with different has_null() implementations (true vs
false)
- Linker picked function_ip_test's vtable, causing has_null() to always
return false
- Wrap Mock classes in anonymous namespace to ensure each TU uses its own
vtable
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
